-
Notifications
You must be signed in to change notification settings - Fork 590
feat(bindings/c)!: Make features configurable via CMakeLists #6143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+15
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f036d6a
to
9f77da9
Compare
Xuanwo
reviewed
May 14, 2025
dab1796
to
e8f661c
Compare
Xuanwo
reviewed
May 15, 2025
70f5732
to
830a503
Compare
Compiling opendal-c v0.0.0 (/home/runner/work/opendal/opendal/bindings/c)
error: the `Err`-variant returned from this function is very large
--> src/operator.rs:89:6
|
89 | ) -> core::Result<core::Operator> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes
|
= help: try reducing the size of `opendal::Error`, for example by boxing large elements or replacing it with `Box<opendal::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: `-D clippy::result-large-err` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::result_large_err)]`
error: could not compile `opendal-c` (lib) due to 1 previous error |
Fixed in #6193 |
830a503
to
c9a3e4f
Compare
Xuanwo
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, thank you a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
This PR has been approved by a maintainer
releases-note/feat
The PR implements a new feature or has a title that begins with "feat"
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #4318.
Closes #4313.
Rationale for this change
What changes are included in this PR?
Enable build feature by option.
Are there any user-facing changes?
Enable build feature by option.