-
Notifications
You must be signed in to change notification settings - Fork 596
refactor(services/aliyun_drive): Move raw request to core #6089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Xuanwo
merged 11 commits into
apache:main
from
jorgehermo9:aliyun_drive-request-refactor
Apr 27, 2025
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
753b8e3
refactor(services/aliyun_drive): Move raw request to core
jorgehermo9 b86b314
fix: clippy lints
jorgehermo9 d291fc3
feat(services/yandex_disk): back to streaming read
jorgehermo9 fef83c9
style: add newline
jorgehermo9 f342e33
feat: refactor into single function
jorgehermo9 4df1df0
chore: change visibility of get_upload_url
jorgehermo9 4ae1a9f
chore: trigger CI again
jorgehermo9 a8553b4
fix: clippy lints
jorgehermo9 42c8384
chore: trigger CI again
jorgehermo9 c091c89
Merge branch 'main' into aliyun_drive-request-refactor
jorgehermo9 333d232
Merge branch 'main' into aliyun_drive-request-refactor
jorgehermo9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -399,6 +399,14 @@ impl AliyunDriveCore { | |
self.send(req, token.as_deref()).await | ||
} | ||
|
||
pub async fn download(&self, download_url: &str, range: BytesRange) -> Result<Buffer> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. similar to how |
||
let req = Request::get(download_url) | ||
.header(header::RANGE, range.to_header()) | ||
.body(Buffer::new()) | ||
.map_err(new_request_build_error)?; | ||
self.send(req, None).await | ||
} | ||
|
||
pub async fn upload(&self, upload_url: &str, body: Buffer) -> Result<Buffer> { | ||
let req = Request::put(upload_url) | ||
// Inject operation to the request. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored this as @erickguan suggested #6089 (comment)