feat(layers/prometheus_client): Add disable_label_root to allow skip root label in metrics #6071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Xuanwo
reviewed
Apr 21, 2025
Xuanwo
changed the title
Xuanwo
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
none
Rationale for this change
currently the
rootlabel might have high cardinality in certain systems, like users may have thousands of differentrootvalues for something likestages.What changes are included in this PR?
this pr addes a
enable_high_cardinality_labelsmethod toPrometheusClientLayerBuilder, if this method set asfalse, therootlabel will not be rendered in the labels encoding.Are there any user-facing changes?
adds a
enable_high_cardinality_labelsinPrometheusClientLayerBuilder. the default behaviour is not changed