Skip to content

feat(core): impl Drop for BlockingWrapper #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 17, 2025

Conversation

asukaminato0721
Copy link
Contributor

Which issue does this PR close?

Closes #5995 .

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@asukaminato0721 asukaminato0721 changed the title Sync check feat(core): impl Drop for BlockingWrapper Apr 16, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review April 16, 2025 12:37
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. core releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Apr 16, 2025
@asukaminato0721 asukaminato0721 requested a review from Xuanwo April 16, 2025 12:44
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2025
@Xuanwo Xuanwo merged commit 2e030d3 into apache:main Apr 17, 2025
242 checks passed
@asukaminato0721 asukaminato0721 deleted the sync-check branch April 17, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync check in opendal need work around
2 participants