Skip to content

ci(bindings/go): include go binding into behavior tests #6018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2025

Conversation

yuchanns
Copy link
Member

@yuchanns yuchanns commented Apr 14, 2025

Part of #4892.

This PR separates the CI for bindings/go into ci/lint and ci/behavior_tests, enabling most of all behavior tests for the Go binding.

Please note that I skipped testing for three services:

I will address these issues sequentially later.

@yuchanns yuchanns force-pushed the ci-bindings-go-behavior-tests branch 22 times, most recently from 9c192b8 to 89571c2 Compare April 14, 2025 10:29
@yuchanns
Copy link
Member Author

yuchanns commented Apr 14, 2025

thread '' panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sqlx-core-0.8.4/src/pool/connection.rs:208:13:
this functionality requires a Tokio context
stack backtrace:
0: rust_begin_unwind
1: core::panicking::panic_fmt
2: sqlx_core::rt::missing_rt
3: sqlx_core::rt::spawn
4: <sqlx_core::pool::connection::PoolConnection as core::ops::drop::Drop>::drop
5: core::ptr::drop_in_place<sqlx_core::pool::connection::PoolConnection<sqlx_sqlite::database::Sqlite>>
6: core::ptr::drop_in_place<tracing::instrument::Instrumented<sqlx_core::pool::executor::<impl sqlx_core::executor::Executor for &sqlx_core::pool::Pool<sqlx_sqlite::database::Sqlite>>::fetch_many<sqlx_core::query::Query<sqlx_sqlite::database::Sqlite,sqlx_sqlite::arguments::SqliteArguments>>::{{closure}}::{{closure}}>>
7: core::ptr::drop_in_place<sqlx_core::ext::async_stream::TryAsyncStream<either::Either<sqlx_sqlite::query_result::SqliteQueryResult,sqlx_sqlite:

@Xuanwo Hi, do you know what should I do to enable the tokio context when running sqlite service?

https://github.com/apache/opendal/actions/runs/14443414830/job/40498759995?pr=6018#step:22:243

@yuchanns yuchanns force-pushed the ci-bindings-go-behavior-tests branch from 89571c2 to 2293b70 Compare April 14, 2025 10:40
@Xuanwo
Copy link
Member

Xuanwo commented Apr 14, 2025

@Xuanwo Hi, do you know what should I do to enable the tokio context when running sqlite service?

https://github.com/apache/opendal/actions/runs/14443414830/job/40498759995?pr=6018#step:22:243

I believe this related to #5995

@yuchanns
Copy link
Member Author

I believe this related to #5995

Oh I guess the sqlite service should be skip for go binding now.

@yuchanns yuchanns force-pushed the ci-bindings-go-behavior-tests branch from 3a2bcfe to 3227ad3 Compare April 15, 2025 01:48
@yuchanns yuchanns marked this pull request as ready for review April 15, 2025 02:03
@yuchanns yuchanns requested a review from Xuanwo as a code owner April 15, 2025 02:03
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 15, 2025
@yuchanns
Copy link
Member Author

I think it is ready

@dosubot dosubot bot added bindings/go github_actions Pull requests that update GitHub Actions code releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" labels Apr 15, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for building this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2025
@Xuanwo Xuanwo merged commit d4d35c9 into main Apr 15, 2025
256 of 257 checks passed
@Xuanwo Xuanwo deleted the ci-bindings-go-behavior-tests branch April 15, 2025 02:33
@yuchanns yuchanns mentioned this pull request Apr 15, 2025
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/go github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants