Skip to content

feat(bindings/go): Add windows platform support #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025
Merged

Conversation

yuchanns
Copy link
Member

@yuchanns yuchanns commented Apr 9, 2025

Close #5051.

Take over #5066.

Part of #4892.

@yuchanns yuchanns force-pushed the go-binding-windows branch from 7a397b4 to b67b593 Compare April 9, 2025 06:02
@yuchanns yuchanns marked this pull request as ready for review April 9, 2025 06:23
@yuchanns yuchanns requested a review from Xuanwo as a code owner April 9, 2025 06:23
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bindings/go github_actions Pull requests that update GitHub Actions code labels Apr 9, 2025
@yuchanns
Copy link
Member Author

yuchanns commented Apr 9, 2025

It is ready.

@yuchanns yuchanns force-pushed the go-binding-windows branch from 00c98eb to 4b2bf75 Compare April 9, 2025 10:04
@Xuanwo Xuanwo changed the title Go binding windows feat(bindings/go): Add windows platform support Apr 9, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yuchanns for this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 9, 2025
@Xuanwo Xuanwo merged commit f66cf1f into main Apr 9, 2025
34 checks passed
@Xuanwo Xuanwo deleted the go-binding-windows branch April 9, 2025 10:33
@yuchanns yuchanns mentioned this pull request Apr 9, 2025
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/go github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new feature: Add windows support for go binding
2 participants