fix(core): Fix head-of-line blocking in concurrent tasks #5941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
the
size:L
Xuanwo
changed the title
dosubot
bot
added
core
releases-note/refactor
github-actions
bot
added
the
releases-note/feat
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
size:M
Xuanwo
changed the title
github-actions
bot
added
the
releases-note/fix
Xuanwo
removed
releases-note/feat
|
Test failed for
I'm working on this. |
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
size:L
meteorgan
reviewed
Apr 2, 2025
Signed-off-by: Xuanwo <[email protected]>
meteorgan
reviewed
Apr 2, 2025
Signed-off-by: Xuanwo <[email protected]>
yihong0618
reviewed
Apr 3, 2025
tisonkun
approved these changes
Apr 3, 2025
yihong0618
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Close #5938
Rationale for this change
Our current
ConcurrentTaskswill poll the first task first before adding new tasks. In the worst cases, we will keep polling the first task without making any progress.This PR removed this poll and only await on the tasks while our queue is full.
What changes are included in this PR?
Are there any user-facing changes?
After this change, opendal can better use concurrent reading/writing.
Before
After