Skip to content

refactor: Migrate aliyun_drive services to context based http client #5815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

miroim
Copy link
Member

@miroim miroim commented Mar 19, 2025

Which issue does this PR close?

Part of #5677

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Behavior tests
cargo test behavior --features tests,services-aliyun-drive -- --test-threads=3 --show-output   
    Finished `test` profile [unoptimized + debuginfo] target(s) in 3.07s
     Running unittests src\lib.rs (target\debug\deps\opendal-df0786b0dd63f43c.exe)

running 0 tests

successes:

successes:

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 134 filtered out; finished in 0.00s

     Running tests\behavior\main.rs (target\debug\deps\behavior-cd77f07915b9c1f1.exe)

running 141 tests
test behavior::test_copy_non_existing_source                           ... ok
test behavior::test_copy_source_dir                                    ... ok
test behavior::test_copy_target_dir                                    ... ok
test behavior::test_copy_self                                          ... ok
test behavior::test_copy_nested                                        ... ok
test behavior::test_copy_file_with_non_ascii_name                      ... ok
test behavior::test_create_dir                                         ... ok
test behavior::test_create_dir_existing                                ... ok
test behavior::test_copy_file_with_ascii_name                          ... ok
test behavior::test_delete_empty_dir                                   ... ok
test behavior::test_delete_file                                        ... ok
test behavior::test_delete_not_existing                                ... ok
test behavior::test_delete_with_special_chars                          ... ok
test behavior::test_remove_one_file                                    ... ok
test behavior::test_delete_with_version                                ... ok
test behavior::test_delete_with_not_existing_version                   ... ok
test behavior::test_batch_delete                                       ... ok
test behavior::test_batch_delete_with_version                          ... ok
test behavior::test_check                                              ... ok
test behavior::test_list_dir                                           ... ok
test behavior::test_list_prefix                                        ... ok
test behavior::test_copy_overwrite                                     ... ok
test behavior::test_list_empty_dir                                     ... ok
test behavior::test_list_non_exist_dir                                 ... ok
test behavior::test_list_sub_dir                                       ... ok
test behavior::test_list_rich_dir                                      ... ok
test behavior::test_list_dir_with_file_path                            ... ok
test behavior::test_list_with_start_after                              ... ok
test behavior::test_list_non_exist_dir_with_recursive                  ... ok
test behavior::test_list_nested_dir                                    ... ok
test behavior::test_list_dir_with_recursive                            ... ok
test behavior::test_list_dir_with_recursive_no_trailing_slash          ... ok
test behavior::test_list_file_with_recursive                           ... ok
test behavior::test_list_root_with_recursive                           ... ok
test behavior::test_list_files_with_versions                           ... ok
test behavior::test_list_with_versions_and_limit                       ... ok
test behavior::test_list_with_versions_and_start_after                 ... ok
test behavior::test_list_files_with_deleted                            ... ok
test behavior::test_remove_all                                         ... ok
test behavior::test_read_range                                         ... ok
test behavior::test_read_full                                          ... ok
test behavior::test_reader_with_if_match                               ... ok
test behavior::test_reader_with_if_none_match                          ... ok
test behavior::test_reader_with_if_modified_since                      ... ok
test behavior::test_reader_with_if_unmodified_since                    ... ok
test behavior::test_read_not_exist                                     ... ok
test behavior::test_read_with_if_match                                 ... ok
test behavior::test_read_with_if_none_match                            ... ok
test behavior::test_read_with_if_modified_since                        ... ok
test behavior::test_read_with_if_unmodified_since                      ... ok
test behavior::test_read_with_dir_path                                 ... ok
test behavior::test_read_with_special_chars                            ... ok
test behavior::test_read_with_override_cache_control                   ... ok
test behavior::test_read_with_override_content_disposition             ... ok
test behavior::test_read_with_override_content_type                    ... ok
test behavior::test_read_with_version                                  ... ok
test behavior::test_read_with_not_existing_version                     ... ok
test behavior::test_rename_file                                        ... ok
test behavior::test_rename_non_existing_source                         ... ok
test behavior::test_rename_source_dir                                  ... ok
test behavior::test_rename_target_dir                                  ... ok
test behavior::test_rename_self                                        ... ok
test behavior::test_reader                                             ... ok
test behavior::test_rename_overwrite                                   ... ok
test behavior::test_stat_file                                          ... ok
test behavior::test_rename_nested                                      ... ok
test behavior::test_stat_dir                                           ... ok
test behavior::test_delete_stream                                      ... ok
test behavior::test_stat_with_special_chars                            ... ok
test behavior::test_stat_not_exist                                     ... ok
test behavior::test_stat_with_if_match                                 ... ok
test behavior::test_stat_with_if_none_match                            ... ok
test behavior::test_stat_with_if_modified_since                        ... ok
test behavior::test_stat_with_if_unmodified_since                      ... ok
test behavior::test_stat_with_override_cache_control                   ... ok
test behavior::test_stat_with_override_content_disposition             ... ok
test behavior::test_stat_with_override_content_type                    ... ok
test behavior::test_stat_root                                          ... ok
test behavior::test_stat_with_version                                  ... ok
test behavior::stat_with_not_existing_version                          ... ok
test behavior::test_stat_nested_parent_dir                             ... ok
test behavior::test_write_with_empty_content                           ... ok
test behavior::test_write_with_dir_path                                ... ok
test behavior::test_stat_not_cleaned_path                              ... ok
test behavior::test_write_with_cache_control                           ... ok
test behavior::test_write_with_content_type                            ... ok
test behavior::test_write_with_content_disposition                     ... ok
test behavior::test_write_with_content_encoding                        ... ok
test behavior::test_write_with_if_none_match                           ... ok
test behavior::test_write_with_if_not_exists                           ... ok
test behavior::test_write_with_if_match                                ... ok
test behavior::test_write_with_user_metadata                           ... ok
test behavior::test_write_only                                         ... ok
test behavior::test_write_returns_metadata                             ... ok
test behavior::test_write_with_special_chars                           ... ok
test behavior::test_writer_write_with_overwrite                        ... ok
test behavior::test_writer_write                                       ... ok
test behavior::test_writer_sink                                        ... ok
test behavior::test_writer_abort                                       ... ok
test behavior::test_writer_abort_with_concurrent                       ... ok
test behavior::test_writer_write_with_concurrent                       ... ok
test behavior::test_writer_futures_copy                                ... ok
test behavior::test_writer_return_metadata                             ... ok
test behavior::test_writer_sink_with_concurrent                        ... ok
test behavior::test_blocking_copy_non_existing_source                  ... ok
test behavior::test_blocking_copy_source_dir                           ... ok
test behavior::test_blocking_copy_target_dir                           ... ok
test behavior::test_blocking_copy_self                                 ... ok
test behavior::test_writer_futures_copy_with_concurrent                ... ok
test behavior::test_blocking_copy_file                                 ... ok
test behavior::test_blocking_create_dir                                ... ok
test behavior::test_blocking_create_dir_existing                       ... ok
test behavior::test_blocking_delete_file                               ... ok
test behavior::test_blocking_remove_one_file                           ... ok
test behavior::test_blocking_list_dir                                  ... ok
test behavior::test_blocking_list_non_exist_dir                        ... ok
test behavior::test_blocking_list_not_exist_dir_with_recursive         ... ok
test behavior::test_blocking_list_dir_with_recursive                   ... ok
test behavior::test_blocking_copy_nested                               ... ok
test behavior::test_blocking_list_file_with_recursive                  ... ok
test behavior::test_blocking_list_dir_with_recursive_no_trailing_slash ... ok
test behavior::test_blocking_read_full                                 ... ok
test behavior::test_blocking_remove_all                                ... ok
test behavior::test_blocking_read_not_exist                            ... ok
test behavior::test_blocking_copy_overwrite                            ... ok
test behavior::test_blocking_rename_non_existing_source                ... ok
test behavior::test_blocking_rename_source_dir                         ... ok
test behavior::test_blocking_read_range                                ... ok
test behavior::test_blocking_rename_target_dir                         ... ok
test behavior::test_blocking_rename_self                               ... ok
test behavior::test_blocking_rename_file                               ... ok
test behavior::test_blocking_stat_file                                 ... ok
test behavior::test_blocking_stat_dir                                  ... ok
test behavior::test_blocking_stat_with_special_chars                   ... ok
test behavior::test_blocking_stat_not_exist                            ... ok
test behavior::test_blocking_write_file                                ... ok
test behavior::test_blocking_write_with_dir_path                       ... ok
test behavior::test_blocking_write_with_special_chars                  ... ok
test behavior::test_blocking_rename_overwrite                          ... ok
test behavior::test_blocking_write_returns_metadata                    ... ok
test behavior::test_blocking_rename_nested                             ... ok

test result: ok. 141 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 651.98s

@miroim miroim requested a review from Xuanwo as a code owner March 19, 2025 04:40
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Mar 19, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @miroim for your contribution!

@Xuanwo Xuanwo merged commit 1947198 into apache:main Mar 19, 2025
92 checks passed
@miroim miroim deleted the migrate-aliyun-context branch March 20, 2025 07:25
@Xuanwo Xuanwo mentioned this pull request Mar 24, 2025
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants