Skip to content

refactor(core/raw)!: Use AccessorInfo instead of seperate fields #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 18, 2025

Which issue does this PR close?

Closes #5795

Rationale for this change

See #5795 for details.

What changes are included in this PR?

  • Use AccessorInfo instead of seperate fields
  • Return Arc<str> instead of String for name and root to avoid copy.

Are there any user-facing changes?

None. Only raw API been touched.

@Xuanwo Xuanwo requested review from koushiro and tisonkun March 18, 2025 04:54
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Mar 18, 2025
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo changed the title refactor: Use AccessorInfo instead of seperate fields refactor(core/raw)!: Use AccessorInfo instead of seperate fields Mar 18, 2025
Copy link
Member

@koushiro koushiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 18, 2025

Thank you @koushiro and @tisonkun for the review.

@Xuanwo Xuanwo merged commit dacfb90 into main Mar 18, 2025
284 checks passed
@Xuanwo Xuanwo deleted the refactor-metrics branch March 18, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AccessorInfo instead of seperate fields
3 participants