feat: Add origin private file system scaffold #5758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Mar 13, 2025
|
Thank you for your review(and I missing it earlier). I will address your suggestions tomorrow. |
Xuanwo
reviewed
Mar 17, 2025
core/src/services/opfs/backend.rs
Outdated
|
|
||
| impl Debug for OpfsConfig { | ||
| fn fmt(&self, _f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| panic!() |
There was a problem hiding this comment.
We can derive it instead of panic.
core/src/services/opfs/backend.rs
Outdated
|
|
||
| impl OpfsBuilder {} | ||
|
|
||
| impl Debug for OpfsBuilder { |
core/src/services/opfs/backend.rs
Outdated
| type BlockingDeleter = (); | ||
|
|
||
| fn info(&self) -> Arc<AccessorInfo> { | ||
| todo!() |
There was a problem hiding this comment.
Let's provide a default AccessorInfo instead.
core/src/services/opfs/error.rs
Outdated
| use crate::Error; | ||
| use crate::ErrorKind; | ||
|
|
||
| impl From<JsValue> for Error { |
There was a problem hiding this comment.
Hi, please implement parse_js_error instead to avoid leak this public API to users.
core/src/services/mod.rs
Outdated
| @@ -148,6 +148,9 @@ pub use obs::*; | |||
| mod onedrive; | |||
| pub use onedrive::*; | |||
|
|
|||
| mod opfs; | |||
There was a problem hiding this comment.
Maybe we need to gate this under cfg(wasm32)?
|
Hi, @Eason0729, to get this PR merged, we will need:
|
|
@Xuanwo, thanks for the feedback. I've just fixed those issues so that:
Please let me know if there's anything else needed! |
Xuanwo
reviewed
Mar 17, 2025
Xuanwo
changed the title
github-actions
bot
added
the
releases-note/feat
Xuanwo
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
close #2442
Rationale for this change
What changes are included in this PR?
read/write support for OPFS
Are there any user-facing changes?