Skip to content

feat(core): Implement write returns metadata for b2 #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Mar 12, 2025

Which issue does this PR close?

Part of #5557

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@hoslo hoslo requested a review from Xuanwo as a code owner March 12, 2025 04:03
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Mar 12, 2025
@hoslo hoslo force-pushed the write_returns_metadata_for_b2 branch from 05c010f to 08e9083 Compare March 12, 2025 04:58
meta.set_content_md5(&md5);
}

if let Some(content_type) = resp.content_type {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add write_with_content_type to the capabilities and add related tests in behavior tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, plz check it.

@hoslo hoslo force-pushed the write_returns_metadata_for_b2 branch from 08e9083 to 8e5e1ae Compare March 13, 2025 12:28
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Xuanwo Xuanwo merged commit b8e778c into main Mar 13, 2025
279 checks passed
@Xuanwo Xuanwo deleted the write_returns_metadata_for_b2 branch March 13, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releases-note/feat The PR implements a new feature or has a title that begins with "feat"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants