Skip to content

ci(website): avoid including rc when calculate the latest version #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Feb 7, 2025

This follows up e15d314.

Otherwise, when we're under a voting release, the version calculate is wrong. For example,

  • When we have v0.51.3-rc.1 and v0.51.2
  • The current git describe --tags --abbrev=0 --match 'v*' gives v0.51.3-rc.1

@tisonkun tisonkun requested a review from Xuanwo as a code owner February 7, 2025 01:36
@github-actions github-actions bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Feb 7, 2025
@Xuanwo Xuanwo merged commit 85e7d55 into main Feb 7, 2025
30 checks passed
@Xuanwo Xuanwo deleted the tisonkun-patch-1 branch February 7, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants