Skip to content

feat(integrations/object_store): add AmazonS3Builder #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

feat(integrations/object_store): add AmazonS3Builder #5456

merged 1 commit into from
Apr 23, 2025

Conversation

meteorgan
Copy link
Contributor

@meteorgan meteorgan commented Dec 25, 2024 •
edited
Loading

Which issue does this PR close?

Part of #5190

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Yes, after adding this new feature, users can use the new API. I'll update the document later.

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Dec 25, 2024
@meteorgan meteorgan force-pushed the object_store_options branch from eb177ef to d9c2049 Compare December 25, 2024 14:32
@meteorgan meteorgan marked this pull request as ready for review December 25, 2024 14:43
Xuanwo
Xuanwo reviewed Apr 7, 2025
View reviewed changes
@meteorgan meteorgan force-pushed the object_store_options branch from d9c2049 to c678304 Compare April 8, 2025 14:09
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 8, 2025
@meteorgan
Copy link
Contributor Author

I've added a new method OpendalStore::new_from_aws_s3_builder, while keeping the methods in S3Builder public. Here are my thoughts:

  1. For users familiar with object_store, they can use new_from_asw_s3_builder to build OpendalStore directly.
  2. For other users, they can utilize S3Builder without needing to understand concepts like operator and S3 in OpenDAL. Additionally, I've intentionally aligned the API in S3Builder with object_store::AmazonS3Builder in both naming and signature.

Xuanwo
Xuanwo reviewed Apr 20, 2025
View reviewed changes
@meteorgan meteorgan force-pushed the object_store_options branch from 989b3c0 to 7c7ff2a Compare April 21, 2025 15:17
Xuanwo
Xuanwo approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I love this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 23, 2025
@Xuanwo Xuanwo merged commit 5232691 into apache:main Apr 23, 2025
242 checks passed
@meteorgan meteorgan deleted the object_store_options branch April 23, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorgan @Xuanwo