feat(services/redis): add support of list operation #5304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
releases-note/feat
|
Funny to see it succeeded on redis but failed on redis cluster and kvrocks. |
|
Fixed. |
Xuanwo
reviewed
Nov 11, 2024
|
|
||
| unsafe impl Sync for RedisScanner {} | ||
|
|
||
| impl Stream for RedisScanner { |
There was a problem hiding this comment.
Hi, how about implement kv::Scan directly without go through Stream?
|
|
||
| #[self_referencing] | ||
| pub struct RedisScanner { | ||
| pool: bb8::Pool<RedisConnectionManager>, |
There was a problem hiding this comment.
We could extract RedisCore as other services do and use Arc<RedisCore> here to avoid duplicate calls like conn_from_pool.
Xuanwo
reviewed
Nov 11, 2024
| @@ -336,6 +387,12 @@ impl kv::Adapter for Adapter { | |||
| Capability { | |||
| read: true, | |||
| write: true, | |||
| // due to limitation of Redis itself, | |||
There was a problem hiding this comment.
Thank you, this is the first time I've learned this. Would you like to add a note in the documents about this backend to make it clear to users?
|
Hi @PragmaTwice, I'm working on #5739 now. And I'm guessing this PR won't be needed anymore after that. Thank you for your working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Currently only read and write is supported for redis service.
After #5208 we can have a better support for kv scanning, so list supporting for redis is relatively easy to implement and can be efficient.
What changes are included in this PR?
We support (async) list operation for redis service via
kv::Adaptor::scanto fetch paged key lists with a prefix using Redis SCAN command.Are there any user-facing changes?
User now can perform list on redis schema.