Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix test_cast #9951

Merged
merged 2 commits into from
Mar 4, 2018
Merged

Fix test_cast #9951

merged 2 commits into from
Mar 4, 2018

Conversation

anirudh2290
Copy link
Member

@anirudh2290 anirudh2290 commented Mar 1, 2018

Description

assert_almost_equal doesn't pass atol and thus results in using default atol of 1e-20. This results in intermittent failures as shown here: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-9869/10/pipeline/466

Tested with the failing seed: 1754533767

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@anirudh2290
Copy link
Member Author

@piiswrong

@anirudh2290
Copy link
Member Author

@marcoabreu did you happen to see this failure with test_random before on windows. I saw this twice today.

@marcoabreu
Copy link
Contributor

Yes, we got some flaky tests unfortunately.

@piiswrong piiswrong merged commit 94d3c06 into apache:master Mar 4, 2018
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants