This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Custom Operator Perf Script and Error Message #18167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rondogency
requested review from
aaronmarkham,
eric-haibin-lin,
leezu and
szha
as code owners
|
@ciyongch Can you tell you if the backport happens on 4.25 11:59 pm? If it is then I can backport this to 1.7 |
|
@rondogency yes, the code freeze will be 4/25 11:59 pm PST. Please arrange your time for this patch, thanks! |
|
@ciyongch after discussion I decide to change this PR to only modify docs and examples and merge it later, so that it won't need to go into 1.7 (no change to binary). You can ignore this PR now. |
|
Ok, then I'll not track this PR in the release, thanks for the update :) |
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, edge, unix-cpu, website, windows-gpu, windows-cpu, unix-gpu, sanity, clang, miscellaneous] |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some minor improvement to C++ custom operator, optionally can go into 1.7
Add reproducible performance test script and improve some error messages. It is an address of comments from PR #17885