Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Opperf] Filter out deprecated ops #15541

Merged
merged 10 commits into from
Aug 16, 2019
Merged

[Opperf] Filter out deprecated ops #15541

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f8d6f95
normal, uniform ops
ChaiBapchya Jul 15, 2019
8406036
Revert "normal, uniform ops"
ChaiBapchya Jul 16, 2019
da3caa7
filter out deprecated ops
ChaiBapchya Jul 16, 2019
1a328ed
Trigger notification
ChaiBapchya Jul 17, 2019
7f53488
additional deprecated ops
ChaiBapchya Jul 18, 2019
3801ba3
Trigger notification
ChaiBapchya Jul 18, 2019
b369c40
Merge branch 'master' into normal_op_opperf
ChaiBapchya Jul 19, 2019
376e840
Trigger notification
ChaiBapchya Jul 19, 2019
83aa9c7
Merge branch 'master' into normal_op_opperf
ChaiBapchya Aug 15, 2019
e9bee74
Trigger notification
ChaiBapchya Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions benchmark/opperf/utils/op_registry_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ def _select_ops(operator_names, filters=("_contrib", "_"), merge_op_forward_back
By default, filter out all Contrib operators that starts with '_contrib' and internal operators that
starts with '_'.

Note - All deprecated operators are filtered out as well.

Parameters
----------
operator_names: List[str]
Expand All @@ -53,6 +55,11 @@ def _select_ops(operator_names, filters=("_contrib", "_"), merge_op_forward_back
mx_operators = {}
operators_with_backward = []

# Filter out deprecated operators
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a "Deprecated" field in the operator metadata?
Because, listing operator by names is not scalable. Everytime we deprecate a operator, we need to come here to add it which soon because un-maintained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some digging around to find there's no exposed API from backend to retrieve deprecated ops. So at the moment, for the sake of this PR can we go ahead with that. I've created another issue to track the same. Sounds good?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeep-krishnamurthy

filters += ("normal", "uniform", "BatchNorm_v1", "Flatten", "contrib_CTCLoss", "Pad", "Cast",
"Pooling_v1", "Concat", "Reshape", "Convolution_v1", "SliceChannel", "Crop",
"crop", "onehot_encode")

if merge_op_forward_backward:
filters += ("_backward",)

Expand Down