[MINVOKER-229] Add a property in invoker.properties to check the failed mojo

[jira-importer]

Romain Manni-Bucau opened MINVOKER-229 and commented

using invoker.buildResult = failure we can check a plugin failed but there is no property to also check which mojo failed.

Issue is you can pass a test where the build failed for another reason than the expected one.

---

No further details from MINVOKER-229

[jira-importer]

Robert Scholte commented

The difference between success or failure is based on the System.exit(code).
There are no more details available, so I can't think of an explicit solution here.
The best practice is to use a post-script to verify the filesystem or the logfile.
MINVOKER-157 is an attempt to warn users that they should verify that this test failed for the right reason.

[jira-importer]

Romain Manni-Bucau commented

Right, which means there are rooms for enhancements. Checking automatically the maven output sounds doable since invoker is the fork owner and would enable to assert the output from invoker.properties.

[jira-importer]

Robert Scholte commented

Assuming you want to use https://maven.apache.org/plugins/maven-invoker-plugin/examples/post-build-script.html
Not sure what you want to add to invoker.porperties

[jira-importer]

Romain Manni-Bucau commented

Something way to do sanity checks on failures without N custom scripts. Typically when you validate all error cases it is a pain for something which should be as easy as putting some string(s) in invoker.properties. you can see it as a default script.

[jira-importer]

Robert Scholte commented

I might have found a solution, but it'll take some time to implement.
Whoever wants to pick this up:

• the maven-invoker-plugin should create a .mvn/extensions.xml referring to some invoker-extension.
• this extension should be part of invoker:install
• A class of this extension should extend the AbstractExecutionListener and implement all fail-methods
• Once called it must inform the maven-invoker-plugin. Probably the easiest solution is to write the info to a new file, being recognized the plugin.