Update created version major #14607
Open
Update created version major #14607
+75
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tsInfos under the right conditions
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
github-project-automation
bot
moved this from Open
to Closed
in OpenSearch Lucene & Core Performance Tracking
github-project-automation
bot
moved this from Closed
to Open
in OpenSearch Lucene & Core Performance Tracking
|
As states on the dev list, I don't think we should do this. |
Can you please elaborate why? I have tried to address the concern you brought up on the mailing list via the implementation in this PR. The primary premise behind the API is that IF all segments of an index are created by the LATEST version, the index in all respects is LATEST. "indexCreatedVersionMajor" should ideally not block a Lucene upgrade in that case. Happy to learn if I am missing anything. |
|
Because that's not what this variable means. If you want to change index backwards compatibility policy, lying about the version is not the way. -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description