Upgrade to gradle 8.14 on branch_10x (backport). #14591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
uschindler
reviewed
Apr 30, 2025
| @@ -379,7 +379,9 @@ private static <A> MMapIndexInputProvider<A> lookupProvider() { | |||
| // access through the lookup: | |||
| final var constr = lookup.findConstructor(cls, MethodType.methodType(void.class, int.class)); | |||
| try { | |||
| return (MMapIndexInputProvider<A>) constr.invoke(maxPermits); | |||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
Is this needed here? This was only to workaround a java 24 bug.
There was a problem hiding this comment.
I assumed that it'd still fail with javac 24 if you're running with that. But apparently it works so it (javac) must be --target (or --source, or --release) sensitive somehow.
There was a problem hiding this comment.
That's why I asked. The compilation with java 24 on Jenkins worked all the time.
It is only an issue if release is targeting 24. They had some language updates. But we should open a bug report about this.
I will make a reproducer and open issue for 24.
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a limited backport of #14533 bumping gradle to v8.14.