Fix TestIndexWriterWithThreads#testIOExceptionDuringAbortWithThreadsOnlyOnce #14424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hreadsOnlyOnce Signed-off-by: guojialiang <[email protected]>
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
…hreadsOnlyOnce Signed-off-by: guojialiang <[email protected]>
…pen-files-after-close-directory
Signed-off-by: guojialiang <[email protected]>
guojialiang92
changed the title
|
Nice! I tested the patch using Fray and confirmed that there is no longer a RuntimeException. You can check how I use Fray to run the test here: https://github.com/aoli-al/lucene/tree/dev/fix-still-exist-open-files-after-close-directory with command |
|
Thank you @aoli-al, looking forward to the reviewer merging this fix. |
|
I think this change is fine and prevents some flakiness :). I will merge and backport to 10x. |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
benwtrent
pushed a commit
that referenced
this pull request
Apr 10, 2025
…nlyOnce (#14424) * fix TestIndexWriterWithThreads#testIOExceptionDuringWriteSegmentWithThreadsOnlyOnce Signed-off-by: guojialiang <[email protected]> * fix TestIndexWriterWithThreads#testIOExceptionDuringWriteSegmentWithThreadsOnlyOnce Signed-off-by: guojialiang <[email protected]> * update Signed-off-by: guojialiang <[email protected]> --------- Signed-off-by: guojialiang <[email protected]>
jpountz
pushed a commit
to jpountz/lucene
that referenced
this pull request
Apr 24, 2025
…nlyOnce (apache#14424) * fix TestIndexWriterWithThreads#testIOExceptionDuringWriteSegmentWithThreadsOnlyOnce Signed-off-by: guojialiang <[email protected]> * fix TestIndexWriterWithThreads#testIOExceptionDuringWriteSegmentWithThreadsOnlyOnce Signed-off-by: guojialiang <[email protected]> * update Signed-off-by: guojialiang <[email protected]> --------- Signed-off-by: guojialiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address issue 14423.
Tests
TestIndexWriterWithThreads#testIOExceptionWithMergeNotEndLongTime. I added the details of the test code to 14423. Because the testTestIndexWriterWithThreads#testIOExceptionWithMergeNotEndLongTimerequires changingIndexWriter#maybeCloseOnTragicEventaccess permissions, I did not include it in the PR.TestIndexWriterWithThreads#testIOExceptionDuringAbortWithThreadsOnlyOnce.Checklist