Skip to content

upgrade icu dependency from 74.2 -> 77.1 #14386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

upgrade icu dependency from 74.2 -> 77.1 #14386

merged 3 commits into from
Mar 21, 2025

Conversation

rmuir
Copy link
Member

@rmuir rmuir commented Mar 21, 2025

Bump dependency
Regenerate locks
Regenerate everything

ICUFoldingFilter:
Remove special-cases from Diacritic Folding, these now have :Diacritic=Yes::

  • U+1734 HANUNOO SIGN PAMUDPOD
  • U+10A3F KHAROSHTHI VIRAMA

ICUTokenizer:
Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates to MidLetter:

  • U+003A COLON
  • U+FE55 SMALL COLON
  • U+FF1A FULLWIDTH COLON

"These tailorings were introduced in ICU 72, but feedback has been negative, and the UTC declined to adopt these changes."

Bump dependency
Regenerate locks
Regenerate everything

ICUFoldingFilter:
Remove special-cases from Diacritic Folding, these now have
`:Diacritic=Yes:`:
* U+1734 HANUNOO SIGN PAMUDPOD
* U+10A3F KHAROSHTHI VIRAMA

ICUTokenizer:
Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates
to `MidLetter`:
* U+003A COLON
* U+FE55 SMALL COLON
* U+FF1A FULLWIDTH COLON

"These tailorings were introduced in ICU 72, but feedback has been
negative, and the UTC declined to adopt these changes."
@rmuir
Copy link
Member Author

rmuir commented Mar 21, 2025

@dweiss i know you dislike the complexity, but the gradlew regenerate really saves a metric ton of human time and prevents mistakes for updates like these.

@dweiss
Copy link
Contributor

dweiss commented Mar 21, 2025

I know, I know. I don't think we should remove it - I just hope it can be implemented in a less hairy way.

@rmuir rmuir added this to the 10.2.0 milestone Mar 21, 2025
@rmuir rmuir merged commit e03af35 into apache:main Mar 21, 2025
8 checks passed
rmuir added a commit that referenced this pull request Mar 21, 2025
Bump dependency
Regenerate locks
Update licenses
Regenerate everything

ICUFoldingFilter:
Remove special-cases from Diacritic Folding, these now have
`:Diacritic=Yes:`:
* U+1734 HANUNOO SIGN PAMUDPOD
* U+10A3F KHAROSHTHI VIRAMA

ICUTokenizer:
Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates
to `MidLetter`:
* U+003A COLON
* U+FE55 SMALL COLON
* U+FF1A FULLWIDTH COLON

"These tailorings were introduced in ICU 72, but feedback has been
negative, and the UTC declined to adopt these changes."
rmuir added a commit to rmuir/lucene that referenced this pull request Mar 21, 2025
Bump dependency
Regenerate locks
Update licenses
Regenerate everything

ICUFoldingFilter:
Remove special-cases from Diacritic Folding, these now have
`:Diacritic=Yes:`:
* U+1734 HANUNOO SIGN PAMUDPOD
* U+10A3F KHAROSHTHI VIRAMA

ICUTokenizer:
Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates
to `MidLetter`:
* U+003A COLON
* U+FE55 SMALL COLON
* U+FF1A FULLWIDTH COLON

"These tailorings were introduced in ICU 72, but feedback has been
negative, and the UTC declined to adopt these changes."
jpountz pushed a commit to jpountz/lucene that referenced this pull request Mar 24, 2025
Bump dependency
Regenerate locks
Update licenses
Regenerate everything

ICUFoldingFilter:
Remove special-cases from Diacritic Folding, these now have
`:Diacritic=Yes:`:
* U+1734 HANUNOO SIGN PAMUDPOD
* U+10A3F KHAROSHTHI VIRAMA

ICUTokenizer:
Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates
to `MidLetter`:
* U+003A COLON
* U+FE55 SMALL COLON
* U+FF1A FULLWIDTH COLON

"These tailorings were introduced in ICU 72, but feedback has been
negative, and the UTC declined to adopt these changes."
jpountz pushed a commit to jpountz/lucene that referenced this pull request Mar 24, 2025
Bump dependency
Regenerate locks
Update licenses
Regenerate everything

ICUFoldingFilter:
Remove special-cases from Diacritic Folding, these now have
`:Diacritic=Yes:`:
* U+1734 HANUNOO SIGN PAMUDPOD
* U+10A3F KHAROSHTHI VIRAMA

ICUTokenizer:
Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates
to `MidLetter`:
* U+003A COLON
* U+FE55 SMALL COLON
* U+FF1A FULLWIDTH COLON

"These tailorings were introduced in ICU 72, but feedback has been
negative, and the UTC declined to adopt these changes."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants