-
Notifications
You must be signed in to change notification settings - Fork 1.1k
upgrade icu dependency from 74.2 -> 77.1 #14386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump dependency Regenerate locks Regenerate everything ICUFoldingFilter: Remove special-cases from Diacritic Folding, these now have `:Diacritic=Yes:`: * U+1734 HANUNOO SIGN PAMUDPOD * U+10A3F KHAROSHTHI VIRAMA ICUTokenizer: Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates to `MidLetter`: * U+003A COLON * U+FE55 SMALL COLON * U+FF1A FULLWIDTH COLON "These tailorings were introduced in ICU 72, but feedback has been negative, and the UTC declined to adopt these changes."
@dweiss i know you dislike the complexity, but the |
I know, I know. I don't think we should remove it - I just hope it can be implemented in a less hairy way. |
dweiss
approved these changes
Mar 21, 2025
rmuir
added a commit
that referenced
this pull request
Mar 21, 2025
Bump dependency Regenerate locks Update licenses Regenerate everything ICUFoldingFilter: Remove special-cases from Diacritic Folding, these now have `:Diacritic=Yes:`: * U+1734 HANUNOO SIGN PAMUDPOD * U+10A3F KHAROSHTHI VIRAMA ICUTokenizer: Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates to `MidLetter`: * U+003A COLON * U+FE55 SMALL COLON * U+FF1A FULLWIDTH COLON "These tailorings were introduced in ICU 72, but feedback has been negative, and the UTC declined to adopt these changes."
rmuir
added a commit
to rmuir/lucene
that referenced
this pull request
Mar 21, 2025
Bump dependency Regenerate locks Update licenses Regenerate everything ICUFoldingFilter: Remove special-cases from Diacritic Folding, these now have `:Diacritic=Yes:`: * U+1734 HANUNOO SIGN PAMUDPOD * U+10A3F KHAROSHTHI VIRAMA ICUTokenizer: Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates to `MidLetter`: * U+003A COLON * U+FE55 SMALL COLON * U+FF1A FULLWIDTH COLON "These tailorings were introduced in ICU 72, but feedback has been negative, and the UTC declined to adopt these changes."
jpountz
pushed a commit
to jpountz/lucene
that referenced
this pull request
Mar 24, 2025
Bump dependency Regenerate locks Update licenses Regenerate everything ICUFoldingFilter: Remove special-cases from Diacritic Folding, these now have `:Diacritic=Yes:`: * U+1734 HANUNOO SIGN PAMUDPOD * U+10A3F KHAROSHTHI VIRAMA ICUTokenizer: Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates to `MidLetter`: * U+003A COLON * U+FE55 SMALL COLON * U+FF1A FULLWIDTH COLON "These tailorings were introduced in ICU 72, but feedback has been negative, and the UTC declined to adopt these changes."
jpountz
pushed a commit
to jpountz/lucene
that referenced
this pull request
Mar 24, 2025
Bump dependency Regenerate locks Update licenses Regenerate everything ICUFoldingFilter: Remove special-cases from Diacritic Folding, these now have `:Diacritic=Yes:`: * U+1734 HANUNOO SIGN PAMUDPOD * U+10A3F KHAROSHTHI VIRAMA ICUTokenizer: Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates to `MidLetter`: * U+003A COLON * U+FE55 SMALL COLON * U+FF1A FULLWIDTH COLON "These tailorings were introduced in ICU 72, but feedback has been negative, and the UTC declined to adopt these changes."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump dependency
Regenerate locks
Regenerate everything
ICUFoldingFilter:
Remove special-cases from Diacritic Folding, these now have
:Diacritic=Yes:
:ICUTokenizer:
Synchronize Default.rbbi to reflect upstream ICU-22941 wordbreak updates to
MidLetter
:"These tailorings were introduced in ICU 72, but feedback has been negative, and the UTC declined to adopt these changes."