-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Optimize ParallelLeafReader to improve term vector fetching efficienc #14373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ParallelLeafReader to improve term vector fetching efficienc #14373
Conversation
Just a gentle reminder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Can you run ./gradlew tidy
to fix formatting issues, and add a changes entry before we merge this?
lucene/core/src/java/org/apache/lucene/index/ParallelLeafReader.java
Outdated
Show resolved
Hide resolved
I successfully ran |
lucene/CHANGES.txt
Outdated
- Fetches all term vectors once per reader instead of per field. | ||
- Reduces complexity from **O(n²) to O(n)**. | ||
- Enhances performance for documents with many fields. (Divyansh Agrawal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally keep a single bullet per changes entry. Details are already available in the pull request that the entry points too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified CHANGES.txt
as you said.
Github build is still failing on spotless (formatting). |
Thanks for the review @vigyasharma ! |
Changes merged. Thanks @DivyanshIITB ! |
This PR optimizes ParallelLeafReader to avoid redundant term vector fetching.
Closes #7926