reformat the python code with 'make reformat' and enable format in CI check #14322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check currently the python code has a mix of indentation, styles, imports ordering, etc. for example, it is very difficult to work with mixed indentation levels: the language is sensitive to indentation. reformat all the code with 'make reformat' and enable format checks when linting. It works like spotless, just don't think about it.
stefanvodita
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
I was looking at the luceneutil PRs, but missed the fact that you were also doing this for Lucene. Thank you @rmuir!
|
thank you @stefanvodita for reviewing (in both places). I am sure it won't go 100% smooth and there will be short-term problems, but I think in the long term it will make things easier. |
|
it is merged, the squash-based merging is not useful for situations like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the python code has a mix of indentation, styles, imports ordering, etc. for example, it is very difficult to work with mixed indentation levels: the language is sensitive to indentation.
reformat all the code with 'make reformat' and enable format checks when linting. It works like spotless, just don't think about it.