Skip to content

python scripts: fix enough so that undefined variable analysis works #14319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

rmuir
Copy link
Member

@rmuir rmuir commented Mar 1, 2025

Fix basic errors from linter and get undefined variable analysis working through the type-checker.

This will detect common problems such as typos, instead of at runtime. The changes are straightforward: cleaning up imports, basic bad things.

Fix basic errors from linter and get undefined variable analysis working
through the type-checker.

This will detect common problems such as typos, instead of at runtime. The
changes are straightforward: cleaning up imports, basic bad things.
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@rmuir rmuir merged commit dfa4494 into apache:main Mar 2, 2025
8 checks passed
rmuir added a commit that referenced this pull request Mar 2, 2025
…14319)

Fix basic errors from linter and get undefined variable analysis working through the type-checker.

This will detect common problems such as typos, instead of at runtime. The changes are straightforward: cleaning up imports, basic bad things.
hanbj pushed a commit to hanbj/lucene that referenced this pull request Mar 12, 2025
…pache#14319)

Fix basic errors from linter and get undefined variable analysis working through the type-checker.

This will detect common problems such as typos, instead of at runtime. The changes are straightforward: cleaning up imports, basic bad things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants