Skip to content

Address gradle temp file pollution insanity #14385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dweiss opened this issue Mar 21, 2025 · 4 comments · Fixed by #14387
Closed

Address gradle temp file pollution insanity #14385

dweiss opened this issue Mar 21, 2025 · 4 comments · Fixed by #14387
Assignees
@dweiss
Labels
type:task
Milestone
10.2.0

Comments

@dweiss
Copy link
Contributor

dweiss commented Mar 21, 2025 •
edited
Loading

Description

Gradle creates temp files it never cleans up. Until this is resolved, let's try to keep some housekeeping ourselves.

Related issues:
@dweiss
Copy link
Contributor Author

dweiss commented Mar 21, 2025

I think the hack we had in https://github.com/apache/lucene-solr/pull/1767/files used to work but gradle must have relocated those temp files...

The fix is simple but I'd like to do some analysis what exactly happened and when first.

@dweiss
Copy link
Contributor Author

dweiss commented Mar 21, 2025

It's this commit that moved the temp folder from java.io.tmpdir, which we redirected and cleaned up.

gradle/gradle@8c2f6b7#diff-a89e26b86bb25dd2df7ef61416478f3b9034cc4625633830a5413a5c5d7124f6

dweiss added a commit to dweiss/lucene that referenced this issue Mar 21, 2025
@dweiss
Clean up junk from gradle's user home (~/.gradle/.tmp). apache#14385
ee53f60
@dweiss dweiss linked a pull request Mar 21, 2025 that will close this issue
Clean up junk from gradle's user home (~/.gradle/.tmp). #14385 #14387
Merged
@dweiss dweiss added this to the 10.2.0 milestone Mar 21, 2025
@dweiss
Copy link
Contributor Author

dweiss commented Mar 21, 2025

Ok, I've added gradle's "user home" tmp cleaning as well. Anything older than 3 hours is removed. This folder may be shared across builds so the time limit is there to prevent accidental cross-build issues.

dweiss added a commit that referenced this issue Mar 21, 2025
@dweiss
Clean up junk from gradle's user home (~/.gradle/.tmp). #14385 (#14387)
c4f1183
dweiss added a commit that referenced this issue Mar 21, 2025
@dweiss
Clean up junk from gradle's user home (~/.gradle/.tmp). #14385 (#14387)
0d8a0cd
@dweiss dweiss self-assigned this Mar 21, 2025
@dweiss dweiss reopened this Mar 21, 2025
@dweiss
Copy link
Contributor Author

dweiss commented Mar 21, 2025

There are also *.log files to wipe clean.

dweiss added a commit that referenced this issue Mar 21, 2025
@dweiss
Include *.out.log files in the cleanup. #14385
6f0ec0b
dweiss added a commit that referenced this issue Mar 21, 2025
@dweiss
Include *.out.log files in the cleanup. #14385
bd85c24
@dweiss dweiss closed this as completed Mar 21, 2025
rmuir pushed a commit to rmuir/lucene that referenced this issue Mar 21, 2025
@dweiss @rmuir
Clean up junk from gradle's user home (~/.gradle/.tmp). apache#14385 (a…
67e08b3 
…pache#14387)
rmuir pushed a commit to rmuir/lucene that referenced this issue Mar 21, 2025
@dweiss @rmuir
Include *.out.log files in the cleanup. apache#14385
1497f91
jpountz pushed a commit to jpountz/lucene that referenced this issue Mar 24, 2025
@dweiss @jpountz
Clean up junk from gradle's user home (~/.gradle/.tmp). apache#14385 (a…
26b8362 
…pache#14387)
jpountz pushed a commit to jpountz/lucene that referenced this issue Mar 24, 2025
@dweiss @jpountz
Include *.out.log files in the cleanup. apache#14385
d7695e9
jpountz pushed a commit to jpountz/lucene that referenced this issue Mar 24, 2025
@dweiss @jpountz
Clean up junk from gradle's user home (~/.gradle/.tmp). apache#14385 (a…
daf4ff6 
…pache#14387)
jpountz pushed a commit to jpountz/lucene that referenced this issue Mar 24, 2025
@dweiss @jpountz
Include *.out.log files in the cleanup. apache#14385
8710ea0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweiss dweiss

Labels
type:task
Projects
None yet
Milestone
10.2.0
Development

Successfully merging a pull request may close this issue.

Clean up junk from gradle's user home (~/.gradle/.tmp). #14385 dweiss/lucene
1 participant
@dweiss