-
Notifications
You must be signed in to change notification settings - Fork 8.8k
feature: support redis config center #7305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YoWuwuuuw
wants to merge
14
commits into
apache:2.x
Choose a base branch
from
YoWuwuuuw:20250418
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7305 +/- ##
============================================
+ Coverage 58.41% 58.49% +0.08%
- Complexity 535 562 +27
============================================
Files 1272 1275 +3
Lines 45865 46082 +217
Branches 5521 5545 +24
============================================
+ Hits 26791 26956 +165
- Misses 16552 16586 +34
- Partials 2522 2540 +18
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#3617
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Architecture(implement 'AbstractConfiguration')
Redis data structure design
Hash strucrture key:
seata: config: SEATA_GROUP
ConfigKey: dataId
Value: content
Channel name:
seata: config:channel:SEATA_GROUP:dataId
Message format:
{operation}-{dataId}-{content}
Example:
put-server.port-8080
Monitoring mechanism
ThreadPool
Details
CONFIG_LISTENERS_MAP
is placed in the callback methodRedisListener.onSubscribe()
, and it will only be put in if the subscription is successfulseata-discovery-redis
moduleⅤ. Special notes for reviews