Skip to content

optimize: raft metadata api #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 14, 2024
Merged

optimize: raft metadata api #6852

merged 8 commits into from
Sep 14, 2024

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title optimize: seata-discovery-raft support xsrf token optimize: Ignore CSRF for metadata APi Sep 14, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.28%. Comparing base (785b20c) to head (dd9c7bb).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...scovery/registry/raft/RaftRegistryServiceImpl.java 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6852      +/-   ##
============================================
- Coverage     52.32%   52.28%   -0.04%     
- Complexity     6413     6414       +1     
============================================
  Files          1083     1083              
  Lines         37918    37918              
  Branches       4494     4494              
============================================
- Hits          19839    19827      -12     
- Misses        16109    16122      +13     
+ Partials       1970     1969       -1     
Files with missing lines Coverage Δ
...a/org/apache/seata/common/util/HttpClientUtil.java 36.58% <ø> (ø)
...scovery/registry/raft/RaftRegistryServiceImpl.java 17.69% <25.00%> (ø)

... and 3 files with indirect coverage changes

@funky-eyes funky-eyes changed the title optimize: Ignore CSRF for metadata APi optimize: raft metadata api Sep 14, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 963f7f3 into apache:2.x Sep 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants