-
Notifications
You must be signed in to change notification settings - Fork 8.8k
optimize: rename namingserver registry type #6827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: rename namingserver registry type #6827
Conversation
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6827 +/- ##
============================================
+ Coverage 52.41% 52.43% +0.01%
- Complexity 6378 6382 +4
============================================
Files 1080 1080
Lines 37558 37558
Branches 4452 4452
============================================
+ Hits 19687 19692 +5
+ Misses 15919 15918 -1
+ Partials 1952 1948 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you missed the following files change:
https://github.com/apache/incubator-seata/tree/2.x/script/client/spring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
rename registry type: namingserver->seasta
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews