Skip to content

optimize: rename namingserver registry type #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Sep 9, 2024

Conversation

ggbocoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

rename registry type: namingserver->seasta

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
# Conflicts:
#	changes/zh-cn/2.x.md
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (145b33c) to head (a5b4fb0).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../apache/seata/discovery/registry/RegistryType.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6827      +/-   ##
============================================
+ Coverage     52.41%   52.43%   +0.01%     
- Complexity     6378     6382       +4     
============================================
  Files          1080     1080              
  Lines         37558    37558              
  Branches       4452     4452              
============================================
+ Hits          19687    19692       +5     
+ Misses        15919    15918       -1     
+ Partials       1952     1948       -4     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...try/namingserver/NamingserverRegistryProvider.java 0.00% <ø> (ø)
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% <ø> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <ø> (ø)
.../apache/seata/discovery/registry/RegistryType.java 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 9, 2024
@funky-eyes funky-eyes added module/discovery discovery module module/common common module labels Sep 9, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit e57fa54 into apache:2.x Sep 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants