-
Notifications
You must be signed in to change notification settings - Fork 8.8k
bugfix: the issue where the TC occasionally fails to go offline from the NamingServer #6781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingfudeshi
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
commented
Aug 26, 2024
...ache/seata/spring/boot/autoconfigure/properties/registry/RegistryNamingServerProperties.java
Outdated
Show resolved
Hide resolved
funky-eyes
commented
Aug 26, 2024
server/src/main/java/org/apache/seata/server/ServerApplication.java
Outdated
Show resolved
Hide resolved
…/main/java/org/apache/seata/spring/boot/autoconfigure/properties/registry/RegistryNamingServerProperties.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.修复tc下线时,由于定时任务没有先关闭,导致下线后还会被注册上,需要靠namingserver的健康检查来下线的bug
2.修复change group时,由于先添加后删除,导致先添加的节点已经注册到了namingserver侧,去删除时使用错了cluster的节点去删除,导致change失败的bug
Fix the bug where TC remains registered after going offline because the scheduled tasks were not stopped first; the issue is dependent on the NamingServer's health check to eventually deregister.
Fix the bug that occurs during a change group operation where nodes are added before being deleted. This causes nodes added first to be registered on the NamingServer side, and the deletion process mistakenly uses the wrong cluster nodes, leading to a change failure.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews