Skip to content

optimize: optimize NacosConfiguration singleton reload #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 18, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add Nacos mock test

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title test: add Nacos mock test optimize: optimize NacosConfiguration singleton reload Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.84%. Comparing base (f7c3866) to head (abc5120).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
.../apache/seata/config/nacos/NacosConfiguration.java 59.09% 2 Missing and 7 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6763      +/-   ##
============================================
+ Coverage     50.57%   50.84%   +0.26%     
- Complexity     5936     5970      +34     
============================================
  Files          1061     1063       +2     
  Lines         37123    37153      +30     
  Branches       4404     4408       +4     
============================================
+ Hits          18776    18889     +113     
+ Misses        16445    16339     -106     
- Partials       1902     1925      +23     
Files Coverage Δ
.../apache/seata/config/nacos/NacosConfiguration.java 41.88% <59.09%> (+29.73%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 18, 2024
@funky-eyes funky-eyes merged commit ff1fa8f into apache:2.x Aug 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants