-
Notifications
You must be signed in to change notification settings - Fork 8.8k
test : old version(< 0.7.1) client test case for multi-version protocol #6695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6695 +/- ##
=========================================
Coverage 50.46% 50.46%
Complexity 5830 5830
=========================================
Files 1051 1051
Lines 36347 36347
Branches 4323 4323
=========================================
Hits 18342 18342
Misses 16187 16187
Partials 1818 1818 |
test-old-version/src/test/java/io/seata/core/rpc/netty/ConfigurationTestHelper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seata-parent 中没有添加该模块,github上ci压根没有跑起来
The module was not added to Ceata Parente, and Gitub didn't run at all last time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
old version(< 0.7.1) client test case for Multi-version protocol
Ⅱ. Does this pull request fix one issue?
fixes #6694
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews