-
Notifications
You must be signed in to change notification settings - Fork 8.8k
optimize: add namingserver distribution #6654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add namingserver distribution #6654
Conversation
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6654 +/- ##
============================================
- Coverage 51.13% 50.71% -0.42%
- Complexity 5317 5702 +385
============================================
Files 950 1034 +84
Lines 33448 35854 +2406
Branches 4048 4253 +205
============================================
+ Hits 17103 18183 +1080
- Misses 14666 15847 +1181
- Partials 1679 1824 +145
|
namingserver/src/main/java/org/apache/seata/namingserver/config/NamingServerConfig.java
Outdated
Show resolved
Hide resolved
namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
Show resolved
Hide resolved
namingserver/src/test/java/org/apache/seata/namingserver/NamingControllerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add change log
done |
…into init-namingserver-distribution # Conflicts: # namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
add namingserver distribution in windows
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews