optimize: add license header for spring config file #6652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6652 +/- ##
============================================
- Coverage 51.13% 50.23% -0.90%
- Complexity 5317 5595 +278
============================================
Files 950 1023 +73
Lines 33448 35440 +1992
Branches 4048 4216 +168
============================================
+ Hits 17103 17803 +700
- Misses 14666 15870 +1204
- Partials 1679 1767 +88 |
funky-eyes
reviewed
Jul 7, 2024
There was a problem hiding this comment.
这个改动会使拥有copyright的其它文件由于格式不同,而被认为没有license header
This change will cause other copyrighted files to be considered without the license header due to their different formats
There was a problem hiding this comment.
Yes, it need to re-run the CI status after the first two PRs are merged.
funky-eyes
reviewed
Jul 8, 2024
slievrly
added a commit
to slievrly/fescar
that referenced
this pull request
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add license header for spring config file
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews