-
Notifications
You must be signed in to change notification settings - Fork 8.8k
feature: init Namingserver #6537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
funky-eyes
reviewed
Jun 21, 2024
common/src/main/java/org/apache/seata/common/metadata/Instance.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/metadata/Node.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/metadata/Node.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/metadata/Node.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/seata/common/metadata/Node.java
Outdated
Show resolved
Hide resolved
namingserver/src/main/java/org/apache/seata/namingserver/NamingController.java
Outdated
Show resolved
Hide resolved
namingserver/src/main/java/org/apache/seata/namingserver/NamingController.java
Outdated
Show resolved
Hide resolved
namingserver/src/main/java/org/apache/seata/namingserver/listener/Watcher.java
Outdated
Show resolved
Hide resolved
namingserver/src/main/java/org/apache/seata/namingserver/manager/ClusterWatcherManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: funkye <[email protected]>
Co-authored-by: funkye <[email protected]>
Co-authored-by: funkye <[email protected]>
Co-authored-by: funkye <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6537 +/- ##
============================================
- Coverage 51.13% 49.06% -2.07%
- Complexity 5317 5463 +146
============================================
Files 950 1023 +73
Lines 33448 35440 +1992
Branches 4048 4216 +168
============================================
+ Hits 17103 17389 +286
- Misses 14666 16372 +1706
Partials 1679 1679
|
funky-eyes
reviewed
Jun 27, 2024
namingserver/src/main/java/org/apache/seata/namingserver/NamingController.java
Outdated
Show resolved
Hide resolved
namingserver/src/main/java/org/apache/seata/namingserver/NamingController.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Jun 28, 2024
namingserver/src/main/java/org/apache/seata/namingserver/NamingController.java
Outdated
Show resolved
Hide resolved
namingserver/src/main/java/org/apache/seata/namingserver/ClusterNotFoundException.java
Outdated
Show resolved
Hide resolved
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
funky-eyes
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
reviewed
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module/common
common module
module/namingserver
module/server
server module
type: feature
Category issues or prs related to feature request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
A Naming Server that provides service registration, service discovery, and service subscription.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews