Skip to content

feature: init Namingserver #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jul 5, 2024
Merged

feature: init Namingserver #6537

merged 32 commits into from
Jul 5, 2024

Conversation

ggbocoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

A Naming Server that provides service registration, service discovery, and service subscription.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 20.77922% with 122 lines in your changes missing coverage. Please review.

Project coverage is 49.06%. Comparing base (933b492) to head (16b705c).
Report is 26 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6537      +/-   ##
============================================
- Coverage     51.13%   49.06%   -2.07%     
- Complexity     5317     5463     +146     
============================================
  Files           950     1023      +73     
  Lines         33448    35440    +1992     
  Branches       4048     4216     +168     
============================================
+ Hits          17103    17389     +286     
- Misses        14666    16372    +1706     
  Partials       1679     1679              
Files Coverage Δ
...c/main/java/org/apache/seata/common/Constants.java 100.00% <ø> (ø)
...java/org/apache/seata/common/result/BaseParam.java 0.00% <ø> (ø)
...main/java/org/apache/seata/common/result/Code.java 0.00% <ø> (ø)
...ava/org/apache/seata/common/result/PageResult.java 0.00% <ø> (ø)
...in/java/org/apache/seata/common/result/Result.java 0.00% <ø> (ø)
...a/org/apache/seata/common/result/SingleResult.java 0.00% <ø> (ø)
...erver/console/controller/GlobalLockController.java 50.00% <ø> (ø)
...er/console/controller/GlobalSessionController.java 50.00% <ø> (ø)
...er/console/impl/db/BranchSessionDBServiceImpl.java 0.00% <ø> (ø)
...erver/console/impl/db/GlobalLockDBServiceImpl.java 0.00% <ø> (ø)
... and 17 more

... and 98 files with indirect coverage changes

@funky-eyes funky-eyes changed the title feature:init namingserver feature: init namingserver Jun 25, 2024
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/namingserver module/common common module labels Jun 26, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Jun 26, 2024
@funky-eyes funky-eyes changed the title feature: init namingserver feature: init Namingserver Jul 2, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the module/server server module label Jul 5, 2024
@funky-eyes funky-eyes merged commit 4d51332 into apache:2.x Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/common common module module/namingserver module/server server module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants