-
Notifications
You must be signed in to change notification settings - Fork 105
SAMOA-59: add an adapter for Apache Gearpump #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pom.xml
Outdated
@@ -127,6 +137,9 @@ | |||
<miniball.version>1.0.3</miniball.version> | |||
<samza.version>0.7.0</samza.version> | |||
<flink.version>0.10.1</flink.version> | |||
<gearpump.version>0.7.5</gearpump.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use the latest 0.8.0 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'll bump it to 0.8.0
Thanks for your work @pangolulu @manuzhang. |
@gdfm I upgraded gearpump version to 0.8.1-SNAPSHOT which includes critical bug fixes and package renaming although that requires manual build. Hopefully we'll release gearpump 0.8.1 soon. |
@manuzhang was there any update from your end on the version of gearpump that we can test Samoa? |
cb00e63
to
a4c3a5e
Compare
@nicolas-kourtellis updated to latest release 0.8.1. Note this is a source release so you have to build gearpump from source. |
@nicolas-kourtellis any updates on this PR ? |
Hi manuzhang, Thanks! Nicolas |
@nicolas-kourtellis We haven't made a binary release yet so the binary for 0.8.1 is temporarily hosted at our old github repo https://github.com/gearpump/gearpump/releases/tag/0.8.1 |
Hi @manuzhang, I managed to get the adapter working. Here are some notes that I would ask you take into consideration:
|
@nicolas-kourtellis Thanks for the detailed review. I'll look into each item and get back to you. |
@manuzhang We are planning a new release, any news on this? |
@abifet It's good to see this project going again. Since it's been quite a while, it will take some time for me to redo the PR so this will probably miss the release. |
Thanks @manuzhang! No problem! |
Hi,
This PR is referenced to SAMOA-59. And how to execute SAMOA with Apache Gearpump, you can follow the README file.
Thanks.