Skip to content

kie-issues#1331: Upgrade to jest 29.x.x on kie-tools #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 26, 2024

Conversation

ljmotta
Copy link
Contributor

@ljmotta ljmotta commented Jun 21, 2024

Closes: apache/incubator-kie-issues#1331

Description

  • Add jest-base to normalize all jest configurations;
  • Moved all __tests__ folders to <package-name>/tests;
  • Moved all __mocks__ folders to <package-name>/tests/__mocks__;
  • Removed test script and jest.config.js file from all packages that doesn't have tests;
  • Update dependencies;

Update summary

Updated dependencies

  • "@jest/globals": "^29.7.0"
  • "@testing-library/jest-dom": "^6.4.6"
  • "@testing-library/react-hooks": "^8.0.1"
  • "@testing-library/react": "^12.1.5"
  • "@types/jest": "^29.5.12"
  • "@types/jest-when": "^3.5.5"
  • "jest": "^29.7.0"
  • "jest-junit": "^16.0.0"
  • "jest-when": "^3.6.0"
  • "ts-jest": "^29.1.5"

Removed dependencies

  • "@types/testing-library__jest-dom": "^5.9.1"
  • "@types/testing-library__react": "^9.1.2"
  • "@types/testing-library__react-hooks": "^3.4.1"

Renamed assertions

  • toBeCalled > toHaveBeenCalled
  • toBeCalledTimes > toHaveBeenCalledTimes
  • toBeCalledWith > toHaveBeenCalledWith
  • toThrownError > toThrow

@ljmotta ljmotta added pr: wip PR is still under development pr: waiting-for-ci CI is still running or broken. labels Jun 21, 2024
@ljmotta ljmotta self-assigned this Jun 21, 2024
@ljmotta ljmotta requested a review from tiagobento as a code owner June 21, 2024 21:21
@ljmotta ljmotta added pr: waiting-for-review Waiting for peer reviews area:dependencies Pull requests that update a dependency file and removed pr: wip PR is still under development pr: waiting-for-ci CI is still running or broken. labels Jun 25, 2024
@tiagobento tiagobento merged commit 8c9206c into apache:main Jun 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Pull requests that update a dependency file pr: waiting-for-review Waiting for peer reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to jest 29.x.x on kie-tools
4 participants