Skip to content

kie-issues#652: Document Dev deployments and its requirements on KIE Sandbox #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

thiagoelg
Copy link
Member

@thiagoelg thiagoelg commented Jun 13, 2024

Closes apache/incubator-kie-issues#652

In this PR:

  • Added/improved dev-deployments documentation;

@thiagoelg thiagoelg requested a review from tiagobento as a code owner June 13, 2024 19:18
@thiagoelg thiagoelg changed the title Document Dev deployments and its requirements on KIE Sandbox kie-issues#652: Document Dev deployments and its requirements on KIE Sandbox Jun 13, 2024
@yesamer
Copy link
Contributor

yesamer commented Jun 17, 2024

Thank you @thiagoelg, that's much better.

Can you please better clarify the image usage with an example?

eg. It expects a Quarkus application to be running at the same host, which it will use to fetch information to render a form that let's users interact with a Decision.

That means we need a canvas_dev_deployment_quarkus_blank_app ?

@thiagoelg
Copy link
Member Author

Thank you @thiagoelg, that's much better.

Can you please better clarify the image usage with an example?

eg. It expects a Quarkus application to be running at the same host, which it will use to fetch information to render a form that let's users interact with a Decision.

That means we need a canvas_dev_deployment_quarkus_blank_app ?

I've fixed some things and added a better README to both the dmn-form-webapp and its image, can you check if it's better now?

@tiagobento
Copy link
Contributor

@thiagoelg Can we try to split this PR in two or make the title more descriptive? I'm afraid a commit with "Documentation" in the title, that changes code, can be misleading in the future.

@thiagoelg
Copy link
Member Author

New PR with code changes to dev-deployment-dmn-form-webapp: #2438

Copy link
Contributor

@ljmotta ljmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagoelg Thanks for the PR. I've got just some minor things to adjust. Great documentation.

Typos/grammar fixes

Co-authored-by: Luiz João Motta <[email protected]>
@tiagobento tiagobento merged commit 2f9f83c into apache:main Jun 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Dev deployments and its requirements on KIE Sandbox
4 participants