-
Notifications
You must be signed in to change notification settings - Fork 221
kie-issues#652: Document Dev deployments and its requirements on KIE Sandbox #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @thiagoelg, that's much better. Can you please better clarify the image usage with an example? eg. That means we need a canvas_dev_deployment_quarkus_blank_app ? |
I've fixed some things and added a better README to both the dmn-form-webapp and its image, can you check if it's better now? |
@thiagoelg Can we try to split this PR in two or make the title more descriptive? I'm afraid a commit with "Documentation" in the title, that changes code, can be misleading in the future. |
6327d6a
to
970451b
Compare
New PR with code changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagoelg Thanks for the PR. I've got just some minor things to adjust. Great documentation.
Typos/grammar fixes Co-authored-by: Luiz João Motta <[email protected]>
Closes apache/incubator-kie-issues#652
In this PR: