Skip to content

NO-ISSUE: Holding alt and navigating away from the page locks the editor #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024

Conversation

kbowers-ibm
Copy link
Contributor

Adding alt to pan was done to simulate the "Pan" action of the legacy DMN Editor, but it isn't ideal when pressing alt and navigating away from the page locks the editor, with e.g. alt+tab, ctrl+alt+delete, holding alt and clicking to a new tab.

Removing this shortcut as using the middle mouse button or the right mouse button allows one to pan around easily.

Copy link
Contributor

@ljmotta ljmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor to remove the keyboard shortcut if we already have another way to pan.

@tiagobento tiagobento merged commit 1d49795 into apache:main May 24, 2024
14 checks passed
@kbowers-ibm kbowers-ibm deleted the no-issue-remove-alt branch May 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants