Skip to content

NO-ISSUE: DMN Editor: Prevent from 'Include model' click in case of empty model #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2024

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented May 22, 2024

Before

Imagine there is folder with two DMN model and both are empty - there is no node or custom data type defined in them. That is a similar to situation to early phase of any project.

Now please follow these steps.

  • lets say models have names a.dmn and b.dmn
  • open the model a
  • click the included models tab
  • try to import the model b
  • you will be in situation like shown in the attached screenshot
  • then press Include model button - Here is the issue, nothing happens

and there will be an error in js console

Now

User is prevented from clicking 'Include model' in case the model can not be included.
Screenshot 2024-05-22 142715

Copy link
Member

@Josephblt Josephblt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, both for empty models and valid ones.
Screenshot from 2024-05-22 10-46-38
Screenshot from 2024-05-22 10-46-48

@tiagobento tiagobento changed the title NO-ISSUE: Prevent from 'Include model' click in case of empty model NO-ISSUE: DMN Editor: Prevent from 'Include model' click in case of empty model May 22, 2024
@@ -0,0 +1,3 @@
.selected-model-to-include-error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the kie-dmn-editor-- prefix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, good point, added in new commit.

@tiagobento tiagobento merged commit f934ac1 into apache:main May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants