NO-ISSUE: DMN Editor: Boxed Expression context menu renders behind other panels #2350
Conversation
| selectLogicTypeContainer.current.style.overflowY = "visible"; | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
Please don't forget to put the dependencies here, otherwise this will execute every time this component re-renders.
There was a problem hiding this comment.
ESLint told me that there are no dependencies required here. When I add it manually he told me to remove.
There was a problem hiding this comment.
Well, ESLint is actually right :) I This is a very specific case where there is no reactivity associated with this effect. All good. Thx!
danielzhe
force-pushed
the
menu-renders-behind
branch
from
da805bf to
6a0fa4b
Compare
danielzhe
added
pr: waiting-for-review
tiagobento
changed the title
There was a problem hiding this comment.
Everything is looking great. I liked the solution with the scroll bar, it solves the rendering problem and it is much easier to use it this way.
There is a small problem, though. It is not a big deal. But if you open the Problems tab, open the context menu, and close the Problems tab, we get this small issue.
This does not affect usability in any way, it just does not look good. This is not urgent but, in my opinion, it would be good if we could address this.
There was a problem hiding this comment.
Hi @danielzhe one question, does this #2350 or #2352 address also context menus for data type selection? On the current main they are quite small/non readable if they are opened next to the border of the screen.
|
@jomarko No. |
|
@Josephblt As we talked in pvt chat, if you keep the menu open its size doesn't change. You have to close it and open it again. |
|
@danielzhe Is this good to merge? |
In a screen with few vertical space available, the context menus was getting hiden. In some cases user can access the content with the browser scrollbar, but most of the cases the content just isn't available. See the pictures bellow:
Before:
After:
https://github.com/apache/incubator-kie-tools/assets/7305741/a1f6e056-0a5c-48e1-8fb0-c7115979ffc5