Skip to content

kie-issues#1163: incubator-kie-tools missing header files (Part IV) #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2024
Merged

kie-issues#1163: incubator-kie-tools missing header files (Part IV) #2320

merged 4 commits into from
May 15, 2024

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented May 14, 2024 •
edited
Loading

Closes apache/incubator-kie-issues#1163

Headers added in:

  • All *.properties files
  • All *.svg files

@porcelli @LightGuard @Josephblt

@yesamer
Copy link
Contributor Author

yesamer commented May 15, 2024

@porcelli @LightGuard We have green checks here, can you please review it and eventually merge it?

porcelli
porcelli approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! almost there :)

@porcelli porcelli merged commit 0f7af59 into apache:main May 15, 2024
14 checks passed
@yesamer yesamer deleted the headers-iv branch May 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcelli porcelli porcelli approved these changes

@Josephblt Josephblt Josephblt approved these changes

@ederign ederign Awaiting requested review from ederign

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

@paulovmr paulovmr Awaiting requested review from paulovmr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incubator-kie-tools missing header files
3 participants
@yesamer @porcelli @Josephblt