NO-ISSUE: Fix Maven Wrapper version and install tar/gzip to dev-deployment-base-image #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoelg
requested review from
ederign,
tiagobento and
paulovmr
as code owners
LightGuard
reviewed
Apr 23, 2024
LightGuard
approved these changes
Apr 23, 2024
tiagobento
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the 3.3.0 release of Maven Wrapper the default method of installing/downloading the wrapper is via
-Dtype=only-script, which means that the .jar file required to run the wrapper os downloaded during runtime, as before it was downloaded during build time with-Dtype=bin.This change breaks the build inside container images that don't have the required binaries to download and extract the Maven Wrapper dependencies (e.g. dev-deployment-kogito-quarkus-blank-app-image didn't have
gzipinstalled from its parent image, causing./mvnwto fail when attempting to extract the wrapper binary).This PR fixes the Maven Wrapper version to 3.3.0 and installs the required dependencies on the dev-deployment-base-image.
More info: https://maven.apache.org/wrapper/