Skip to content

kie-issues#1014: KIE Sandbox: Enabling Validation for DMN Assets up to 1.5 #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented Mar 15, 2024

Closes apache/incubator-kie-issues#1014

The alternative is to remove that block of code, but I guess it will be useful to have for future DMN versions... (1.6 is coming... :) )

@ljmotta @tiagobento

@tiagobento
Copy link
Contributor

@yesamer Thank you for this PR! I have to say, however, that we won't see the effects of apache/incubator-kie-drools#5785 in KIE Sandbox until we upgrade KIE Tools to a new timestamped SNAPSHOT of Kogito Runtimes... Btw, is 999-20240218-SNAPSHOT already compatible with DMN 1.5?

@yesamer
Copy link
Contributor Author

yesamer commented Mar 15, 2024

@tiagobento The main PR we implemented for DMN 1.5 was merged at the end of January (here). That means the 02-18 snapshot supports 1.5, but not all the new features. Speaking of the validation, we need to wait next snapshot (03-17) to have a 100% compatible validation logic with all 1.5 features
Considering we're targeting 10.0 release, I don't believe it's too risky to merge it now.
In addition, I would appreciate having it merged because we're using the dev environment (https://sandbox.kie.org/dev/#/) to test the editor-jitexecutor integration, and enabling the Validation there would help a lot.
However, if you prefer to postpone the merge after the update to the 03-17 snapshot update to minimize any risk, that's fine for me, I trust your judgment.

@tiagobento
Copy link
Contributor

tiagobento commented Mar 15, 2024

@yesamer Great. Thanks for the details. I'm absolutely fine with merging it now. Don't need to wait for all validation capabilities to be available to merge it. Approving!

@tiagobento tiagobento merged commit ba5de57 into apache:main Mar 16, 2024
paulovmr pushed a commit to kiegroup/kie-tools that referenced this pull request Mar 28, 2024
@yesamer yesamer deleted the kie-issues#1014 branch February 24, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KIE Sandbox: Enabling Validation for DMN Assets up to 1.5
3 participants