Skip to content

kie-issues#1004: Start Chrome extensions tests with empty browser data #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2024
Merged

kie-issues#1004: Start Chrome extensions tests with empty browser data #2194

merged 3 commits into from
Mar 19, 2024

Conversation

tomasdavidorg
Copy link
Contributor

@tomasdavidorg tomasdavidorg commented Mar 11, 2024 •
edited
Loading

Fixes: apache/incubator-kie-issues#1004

  • Add parameter user-data-dir to start browser with clean data
  • Add parameters disable-web-security, remote-allow-origins=*, disable-gpu for better test stability
  • When token is used reset button is clicked before the token is added to secure clean input

@tomasdavidorg tomasdavidorg added waiting-for-qe pr: waiting-for-review Waiting for peer reviews pr: waiting-for-ci CI is still running or broken. lang:typescript Pull requests that update Javascript code labels Mar 11, 2024
@tomasdavidorg tomasdavidorg reopened this Mar 12, 2024
@tomasdavidorg tomasdavidorg removed the pr: waiting-for-ci CI is still running or broken. label Mar 13, 2024
@LuboTerifaj LuboTerifaj self-requested a review March 14, 2024 14:51
LuboTerifaj
LuboTerifaj approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@LuboTerifaj LuboTerifaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks @tomasdavidorg

@paulovmr paulovmr removed the pr: waiting-for-review Waiting for peer reviews label Mar 14, 2024
@LuboTerifaj LuboTerifaj merged commit 138146f into apache:main Mar 19, 2024
@tomasdavidorg tomasdavidorg deleted the kie-issues#1004 branch March 19, 2024 12:15
paulovmr pushed a commit to kiegroup/kie-tools that referenced this pull request Mar 28, 2024
@tomasdavidorg @paulovmr
kie-issues#1004: Start Chrome extensions tests with empty browser data (
9ecb014 
apache#2194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulovmr paulovmr paulovmr approved these changes

@LuboTerifaj LuboTerifaj LuboTerifaj approved these changes

@ederign ederign Awaiting requested review from ederign

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

Assignees
No one assigned
Labels
lang:typescript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start Chrome extensions tests with empty browser data
3 participants
@tomasdavidorg @paulovmr @LuboTerifaj