kie-issues#833: Move all UI packages from kogito-apps to kie-tools
#2180
Conversation
thiagoelg
requested review from
ederign,
tiagobento and
paulovmr
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| let sourceString; | ||
|
|
||
| const configString = fs.readFileSync(path.join(`${__dirname}/forms/examples/${formName}.config`), "utf8"); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
|
|
||
| const configString = fs.readFileSync(path.join(`${__dirname}/forms/examples/${formName}.config`), "utf8"); | ||
| if (formInfo[0].type.toLowerCase() === "html") { | ||
| sourceString = fs.readFileSync(path.join(`${__dirname}/forms/examples/${formName}.html`), "utf8"); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| if (formInfo[0].type.toLowerCase() === "html") { | ||
| sourceString = fs.readFileSync(path.join(`${__dirname}/forms/examples/${formName}.html`), "utf8"); | ||
| } else if (formInfo[0].type.toLowerCase() === "tsx") { | ||
| sourceString = fs.readFileSync(path.join(`${__dirname}/forms/examples/${formName}.tsx`), "utf8"); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| res.send(null); | ||
| } | ||
| } catch (error) { | ||
| res.status(404).send(error); |
Check warning
Code scanning / CodeQL
Information exposure through a stack trace
| res.send(null); | ||
| } | ||
| } catch (error) { | ||
| res.status(404).send(error); |
Check warning
Code scanning / CodeQL
Information exposure through a stack trace
| app.post("/management/processes/:processId/instances/:processInstanceId/nodes/:nodeId", controller.callNodeTrigger); | ||
| app.get("/management/processes/:processId/nodes", controller.getTriggerableNodes); | ||
| app.delete("/jobs/:jobId", controller.callJobCancel); | ||
| app.get("/svg/processes/:processId/instances/:id", controller.dispatchSVG); |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
|
||
| app.get("/forms/list", controller.getForms); | ||
| app.get("/customDashboard/list", controller.getCustomDashboards); | ||
| app.get("/customDashboard/:name", controller.getCustomDashboardContent); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| app.get("/forms/list", controller.getForms); | ||
| app.get("/customDashboard/list", controller.getCustomDashboards); | ||
| app.get("/customDashboard/:name", controller.getCustomDashboardContent); | ||
| app.get("/forms/:formName", controller.getFormContent); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| } | ||
| if (req.body.kogitobusinesskey) { | ||
| console.log(`Starting Serverless workflow with business key: ${req.body.kogitobusinesskey}`); | ||
| return res.status(200).send(req.body.kogitobusinesskey); |
Check failure
Code scanning / CodeQL
Reflected cross-site scripting
| return res.status(200).send(req.body.kogitobusinesskey); | ||
| } else if (req.body.kogitoprocrefid) { | ||
| console.log(`Serverless Workflow with id ${req.body.kogitoprocrefid} successfully completed`); | ||
| return res.status(200).send(req.body.kogitoprocrefid); |
Check failure
Code scanning / CodeQL
Reflected cross-site scripting
* RUNTIME_TOOLS_PROCESS_DEV_UI_WEBAPP__kogitoAppUrl: allows devUI to connect to a remote kogito application (default empty) * RUNTIME_TOOLS_PROCESS_DEV_UI_WEBAPP__openApiDocPath: allows configuring the path to the openapi doc (default /q/openapi.json)
pefernan
force-pushed
the
kogito-apps-migration
branch
from
023339f to
fd77544
Compare
apache#2180) Co-authored-by: Pere Fernández <[email protected]>
Reference: apache/incubator-kie-issues#833
Summary of the migration
Migrated packages from kogito-apps:
All dependencies of those packages that weren't previously migrated were migrated as well and were distributed across the new or renamed packages:
Unit and end-to-end tests
Most unit tests were stripped out of those packages since they weren't really testing anything.
End-to-end tests were also stripped out but may come back at a later stage, they were not considered right now due to the time it would take to set it up.
Testing and validating this PR locally
Follow the steps below:
To fetch the branch from my fork without adding my fork as a remote, use this command:
then checkout the
kogito-apps-migrationbranch.Build the new packages with:
Then run them individually:
You may also run the
devcommand instead ofstartto use the mock server (in this case, setting the environment variable is not necessary).