Skip to content

KOGITO-10018: SWF Editor - Integrate SWF diagram editor theme API with VsCode and Combined Editor #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 27, 2024
Merged

KOGITO-10018: SWF Editor - Integrate SWF diagram editor theme API with VsCode and Combined Editor #2164

merged 24 commits into from
Mar 27, 2024

Conversation

handreyrc
Copy link
Contributor

@handreyrc handreyrc commented Feb 16, 2024 •
edited
Loading

SWF Diagram Editor theme support.

JIRA: KOGITO-10018
JIRA: KOGITO-10016
JIRA: KOGITO-10015

Screenshots:
combined_theme
vscode_theme

@handreyrc handreyrc requested a review from caponetto February 16, 2024 21:37
@tiagobento
Copy link
Contributor

@handreyrc Instead of creating kogitoEditor_created, couldn't we add a new property to EditorInitArgs instead?

@handreyrc
Copy link
Contributor Author

Hey @caponetto,

I created a new epic so we can close this one and still keep track of the issues and improvements you reported above.

Epic: KOGITO-10071

Thanks

@tiagobento tiagobento merged commit 507e974 into apache:main Mar 27, 2024
paulovmr pushed a commit to kiegroup/kie-tools that referenced this pull request Mar 28, 2024
@handreyrc @paulovmr
KOGITO-10018: SWF Editor - Integrate SWF diagram editor theme API wit…
4389c22 
…h VsCode and Combined Editor (apache#2164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caponetto caponetto caponetto approved these changes

@paulovmr paulovmr paulovmr approved these changes

@tiagobento tiagobento tiagobento approved these changes

@tomasdavidorg tomasdavidorg tomasdavidorg approved these changes

@ederign ederign Awaiting requested review from ederign

Assignees
No one assigned
Labels
area:core area:sonataflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@handreyrc @tiagobento @caponetto @tomasdavidorg @paulovmr