kie-issues#669: The DMN Editor should allow using the new alternative representation of InputData nodes (DMN 1.5) #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljmotta
requested review from
ederign,
tiagobento and
paulovmr
as code owners
tiagobento
requested changes
Feb 7, 2024
There was a problem hiding this comment.
@ljmotta Awesome PR! Thanks a lot for this work. Indeed a great addition to the DMN Editor.
My two most important comments here are related to two things:
- Unnecessary use of reactivity when you could rely on the state object directly. (This is something I think we should reassess.. I mean, for
useCallbackhooks, reacvitity need is really rare... as we could simply dodmnEditorStoreApi.getState()and use the most up-to-date state, right?) - Optional positional boolean parameter. This really is a great source of bugs, and I think we should really avoid them. It's really easy to convert positional parameters to object parameters in VS Code too! [1]). Also, for non-positional parameters, we should also try and make it not optional. It's too easy to forget it somewhere.
[1]
Screen.Recording.2024-02-07.at.11.04.07.mov
packages/dmn-editor/src/store/computed/computeIsAlternativeInputDataShape.ts
Outdated
Show resolved
Hide resolved
tiagobento
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#669
Description
This PR adds the alternative input data node shape into the new DMN Editor. Now, it's possible to change the input data node shape on each DRD separately.
To accommodate those changes, the DRD selector was changed, showing the selected DRD properties. Also, the dropdown doesn't close on the DRD select, giving the user the option to check the properties before manually closing it.
Video
Untitled.video.-.Made.with.Clipchamp.4.mp4