NO-ISSUE: Fix Windows boxed-expression-component Storybook start script
#2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljmotta
requested review from
ederign,
tiagobento and
paulovmr
as code owners
tiagobento
approved these changes
Feb 1, 2024
jomarko
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Thank you @ljmotta
Windows run seems playwright tests were started, some skipped, but no failures. So probably we are fine.
https://github.com/apache/incubator-kie-tools/actions/runs/7743209943?pr=2139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR
This PR creates a specific start script for Windows using
powershell.Problem
To evaluate the
$(build-env ... )on windows is required the usage of thepowershellscript, which requires the command to be wrapped on double quotes. Wrapping thestorybookArgson single quotes prevents the$(build-env ... )evaluation. Therefore, the usage of an environment variable.