Skip to content

kie-issues#831: Make the new DMN Editor actually generate an SVG representing the currently open DRD #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

tiagobento
Copy link
Contributor

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @tiagobento . I focused more on manual check in VS Code. Should be this generate svg feature tested also on some other channel? If yes, please let me know how,

My findings are:

01 node text color

Is ignored. See the attached screenshot. In the SVG all node text are black, while most nodes in original diagram uses different node text color.
image

02 node styling applied unexpectedly

is probably unrelated to your PR, but not sure, so sharing it here. If you confirm it is unrelated, we can report, if the team will agree, separately.

  • Open some diagram that contains some non default nodes, it means their colors and fonts are not only black and white.
  • Then start clicking these non default nodes.
  • They will be automatically re-styled do default black and white.

The same is doable also vice versa

  • Open some node styling properties
  • Change the node color or font
  • Select another node
  • This last selected node will be automatically re-styled as the previously selected node

@ljmotta
Copy link
Contributor

ljmotta commented Jan 18, 2024

@jomarko I could reproduce this issue on the daily-dev environment. Changing the node fill color, stroke color and font color resets to the default. It appears the DMN Editor is not saving the colors anymore.

@tiagobento
Copy link
Contributor Author

@jomarko Thanks a lot for testing it. It should be fixed now.

@ljmotta
Copy link
Contributor

ljmotta commented Jan 19, 2024

@tiagobento @jomarko I've create an issue to track the node style bug

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think I can not help with code review in this case, as it is quite big for my current skills. Approving as findings from the manual check were addressed.

@tiagobento tiagobento merged commit b108e14 into apache:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the new DMN Editor actually generate an SVG representing the currently open DRD.
5 participants